Add Red Hat family distro module and Fedora distro module #252
Conversation
Conan-Kudo
force-pushed
the
add-fedora
branch
2 times, most recently
from
9cf4a64
to
6688255
Compare
|
Hi @Conan-Kudo, thanks for the contributions 👍 . One last piece to update is the set_distro method which gets the class based on the distro_name argument. https://github.com/SUSE-Enceladus/img-proof/blob/master/img_proof/ipa_cloud.py#L377 As a note the distro_name provided is converted to lowercase prior to comparison. Also, all commits should be signed. I have some information on getting a signing key setup in a gist https://gist.github.com/smarlowucf/25dbd6021da1a8bdece248fa8d7ece71#create-pgp-key-for-signing-commits-and-add-public-key-to-github-account. Hope this helps. |
This change adds support for testing Red Hat based distributions, and adds a Fedora module for testing Fedora cloud images. Signed-off-by: Neal Gompa <[email protected]>
|
@smarlowucf I'm not entirely sure why you force GPG signed commits (they're not particularly useful in this model of contributions), but here you go, signed commits... |
|
Looks good, thanks 👍 . |
This change adds support for testing Red Hat based distributions, and adds a Fedora module for testing Fedora cloud images.
This PR is the beginning of investigating using
img_prooffor automatically testing Fedora Cloud Edition images by the Fedora Cloud SIG.(cc: @dustymabe, @major)